Skip to content

operations: add const qualifier in collect family of functions #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

meyerj
Copy link
Member

@meyerj meyerj commented May 16, 2019

From ed84012 (by @psoetens):

There was no need to have this non-const. non-const prevented us to use it on a const& to a SendHandle, which we do need if the SendHandle is presented by a DataSource.

This commit is part of unmerged #84, but actually independent.

There was no need to have this non-const. non-const prevented us
to use it on a const& to a SendHandle, which we do need if the
SendHandle is presented by a DataSource.

Signed-off-by: Peter Soetens <[email protected]>
@meyerj meyerj added this to the 2.9 milestone May 16, 2019
Copy link
Contributor

@francisco-miguel-almeida francisco-miguel-almeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisco-miguel-almeida francisco-miguel-almeida merged commit 07f24ba into master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants