Skip to content

Reverse condition $this->isFeaturesEnabled to !$this->isFeaturesEnabled#296

Open
JanuszWitrykus wants to merge 1 commit intooroinc:masterfrom
JanuszWitrykus:master
Open

Reverse condition $this->isFeaturesEnabled to !$this->isFeaturesEnabled#296
JanuszWitrykus wants to merge 1 commit intooroinc:masterfrom
JanuszWitrykus:master

Conversation

@JanuszWitrykus
Copy link
Copy Markdown

@JanuszWitrykus JanuszWitrykus commented Dec 29, 2017

This is probably error, as I confirmed with author, in file TrackingVisitEventProvider.php condition should be reversed (NOT)

@orocla
Copy link
Copy Markdown

orocla commented Jan 11, 2018

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for some time for the submission to be processed.

@vladimirseniuk
Copy link
Copy Markdown
Contributor

Thank you for the proposed bug fix.
Internal ID: CRM-8725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants