fix(angular): emit filterParams for untagged ops in tags-split default file

packages/angular/src/http-client.test.ts

@@ -18,6 +18,7 @@ import {
   getHttpClientReturnTypes,
   resetHttpClientReturnTypes,
 } from './http-client';
+import { createQueryParams } from './test-helpers';
 
 // ---------------------------------------------------------------------------
 // Test helpers
@@ -180,7 +181,7 @@ const createVerbOption = (
       definition: '',
       imports: [],
       schemas: [],
-      originalSchema: {} as never,
+      originalSchema: { type: 'object' },
       contentType: '',
       formData: '',
       formUrlEncoded: '',
@@ -225,6 +226,21 @@ const createVerbOption = (
     ...overrides,
   }) as GeneratorVerbOptions;
 
+const createHeaderParams = (
+  overrides: Partial<Parameters<typeof generateAngularHeader>[0]> = {},
+): Parameters<typeof generateAngularHeader>[0] => ({
+  title: 'PetService',
+  isRequestOptions: true,
+  isMutator: false,
+  isGlobalMutator: false,
+  provideIn: 'root',
+  hasAwaitedType: false,
+  output: createOutput(),
+  verbOptions: { getPetById: createVerbOption() },
+  clientImplementation: '',
+  ...overrides,
+});
+
 const createContextSpec = (output: NormalizedOutputOptions): ContextSpec => {
   const spec = {
     openapi: '3.1.0',
@@ -408,6 +424,69 @@ describe('angular HttpClient generator', () => {
 
       expect(header).not.toContain('type ThirdParameter');
     });
+
+    it('emits filterParams helper for untagged operations in tags-split default file (#3103)', () => {
+      const verbOptionWithQueryParams = createVerbOption({
+        tags: [],
+        queryParams: createQueryParams({
+          schema: { name: 'GetApiProductParams', model: '', imports: [] },
+        }),
+      });
+
+      const header = generateAngularHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: { getApiProduct: verbOptionWithQueryParams },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).toContain('function filterParams(');
+    });
+
+    it('includes both explicit default-tagged and untagged operations in the default bucket', () => {
+      const untaggedVerb = createVerbOption({
+        operationId: 'getUntaggedProduct',
+        tags: [],
+        queryParams: createQueryParams({
+          schema: { name: 'GetApiProductParams', model: '', imports: [] },
+        }),
+      });
+      const explicitDefaultVerb = createVerbOption({
+        operationId: 'getTaggedDefaultProduct',
+        tags: ['default'],
+      });
+
+      const header = generateAngularHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: {
+            getUntaggedProduct: untaggedVerb,
+            getTaggedDefaultProduct: explicitDefaultVerb,
+          },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).toContain('function filterParams(');
+    });
+
+    it('does not enable the implicit default bucket when only explicit default tags exist', () => {
+      const explicitDefaultVerb = createVerbOption({
+        operationId: 'getTaggedDefaultProduct',
+        tags: ['default'],
+      });
+
+      const header = generateAngularHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: { getTaggedDefaultProduct: explicitDefaultVerb },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).not.toContain('function filterParams(');
+    });
   });
 
   // ── Footer ────────────────────────────────────────────────────────────

packages/angular/src/http-client.ts

@@ -1,5 +1,4 @@
 import {
-  camel,
   type ClientBuilder,
   type ClientDependenciesBuilder,
   type ClientFooterBuilder,
@@ -33,6 +32,7 @@ import {
 } from './types';
 import {
   createReturnTypesRegistry,
+  getRelevantVerbOptionsForTag,
   getSchemaOutputTypeRef,
   isPrimitiveType,
   isZodSchemaOutput,
@@ -230,11 +230,7 @@ export const generateAngularHeader: ClientHeaderBuilder = ({
 }) => {
   returnTypesRegistry.reset();
 
-  const relevantVerbs = tag
-    ? Object.values(verbOptions).filter((v) =>
-        v.tags.some((t) => camel(t) === camel(tag)),
-      )
-    : Object.values(verbOptions);
+  const relevantVerbs = getRelevantVerbOptionsForTag(verbOptions, tag);
   const hasQueryParams = relevantVerbs.some((v) => v.queryParams);
   const acceptHelpers = buildAcceptHelpers(relevantVerbs, output);
 
@@ -471,7 +467,6 @@ export const generateHttpClientImplementation = (
   let paramsDeclaration = '';
   if (angularParamsRef && queryParams) {
     if (isRequestOptions) {
-      // Uses the shared filterParams helper emitted in the file header
       const callExpr = getAngularFilteredParamsCallExpression(
         '{...params, ...options?.params}',
         queryParams.requiredNullableKeys ?? [],
@@ -480,7 +475,6 @@ export const generateHttpClientImplementation = (
         ? `const ${angularParamsRef} = ${paramsSerializer.name}(${callExpr});\n\n    `
         : `const ${angularParamsRef} = ${callExpr};\n\n    `;
     } else {
-      // No shared helper available; use inline IIFE filtering
       const iifeExpr = getAngularFilteredParamsExpression(
         'params ?? {}',
         queryParams.requiredNullableKeys ?? [],

packages/angular/src/http-resource.test.ts

@@ -19,6 +19,7 @@ import {
   getAngularHttpResourceOnlyDependencies,
   routeRegistry,
 } from './http-resource';
+import { createQueryParams } from './test-helpers';
 
 interface AngularOverride {
   provideIn: 'root' | 'any' | boolean;
@@ -226,7 +227,7 @@ const createVerbOption = (
       definition: '',
       imports: [],
       schemas: [],
-      originalSchema: {} as never,
+      originalSchema: { type: 'object' },
       contentType: '',
       formData: '',
       formUrlEncoded: '',
@@ -273,6 +274,21 @@ const createVerbOption = (
   } as GeneratorVerbOptions;
 };
 
+const createHeaderParams = (
+  overrides: Partial<Parameters<typeof generateHttpResourceHeader>[0]> = {},
+): Parameters<typeof generateHttpResourceHeader>[0] => ({
+  title: 'PetService',
+  isRequestOptions: true,
+  isMutator: false,
+  isGlobalMutator: false,
+  provideIn: 'root',
+  hasAwaitedType: false,
+  output: createOutput(),
+  verbOptions: { getPetById: createVerbOption() },
+  clientImplementation: '',
+  ...overrides,
+});
+
 describe('angular httpResource generator', () => {
   beforeEach(() => {
     routeRegistry.reset();
@@ -1075,6 +1091,71 @@ describe('angular httpResource generator', () => {
       expect(header).toContain('getPetByIdResource');
       expect(header).toContain('healthCheckResource');
     });
+
+    it('emits filterParams helper for untagged operations in tags-split default file (#3103)', () => {
+      const verbOptionWithQueryParams = createVerbOption({
+        tags: [],
+        queryParams: createQueryParams({
+          schema: { name: 'GetApiProductParams', model: '', imports: [] },
+        }),
+      });
+      routeRegistry.set('getPetById', '/api/pets/${petId}');
+
+      const header = generateHttpResourceHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: { getPetById: verbOptionWithQueryParams },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).toContain('function filterParams(');
+    });
+
+    it('includes both explicit default-tagged and untagged operations in the default bucket', () => {
+      const untaggedVerb = createVerbOption({
+        operationId: 'getUntaggedProduct',
+        tags: [],
+        queryParams: createQueryParams({
+          schema: { name: 'GetApiProductParams', model: '', imports: [] },
+        }),
+      });
+      const explicitDefaultVerb = createVerbOption({
+        operationId: 'getTaggedDefaultProduct',
+        tags: ['default'],
+      });
+
+      const header = generateHttpResourceHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: {
+            getUntaggedProduct: untaggedVerb,
+            getTaggedDefaultProduct: explicitDefaultVerb,
+          },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).toContain('function filterParams(');
+    });
+
+    it('does not enable the implicit default bucket when only explicit default tags exist', () => {
+      const explicitDefaultVerb = createVerbOption({
+        operationId: 'getTaggedDefaultProduct',
+        tags: ['default'],
+      });
+      routeRegistry.set('getTaggedDefaultProduct', '/api/products/default');
+
+      const header = generateHttpResourceHeader(
+        createHeaderParams({
+          title: 'DefaultService',
+          verbOptions: { getTaggedDefaultProduct: explicitDefaultVerb },
+          tag: 'default',
+        }),
+      );
+
+      expect(header).not.toContain('function filterParams(');
+    });
   });
 
   // ─── Response type factories ──────────────────────────────────────

packages/angular/src/http-resource.ts

@@ -1,5 +1,4 @@
 import {
-  camel,
   type ClientBuilder,
   type ClientDependenciesBuilder,
   type ClientExtraFilesBuilder,
@@ -51,6 +50,7 @@ import {
   createReturnTypesRegistry,
   createRouteRegistry,
   getDefaultSuccessType,
+  getRelevantVerbOptionsForTag,
   getSchemaOutputTypeRef,
   isMutationVerb,
   isPrimitiveType,
@@ -162,16 +162,6 @@ const resourceReturnTypesRegistry = createReturnTypesRegistry();
 /** @internal Exported for testing only */
 export const routeRegistry = createRouteRegistry();
 
-const getRelevantVerbOptions = (
-  verbOptions: Record<string, GeneratorVerbOptions>,
-  tag?: string,
-): GeneratorVerbOptions[] =>
-  tag
-    ? Object.values(verbOptions).filter((verbOption) =>
-        verbOption.tags.some((currentTag) => camel(currentTag) === camel(tag)),
-      )
-    : Object.values(verbOptions);
-
 const getVerbOptionsRecord = (
   verbOptions: readonly GeneratorVerbOptions[],
 ): Record<string, GeneratorVerbOptions> =>
@@ -1227,7 +1217,7 @@ export const generateHttpResourceHeader: ClientHeaderBuilder = ({
   // the shared header duplicates helpers across every tag file and pulls in
   // type names the file-local `imports` filter never sees, producing missing
   // schema imports in the generated output.
-  const relevantVerbOptions = getRelevantVerbOptions(verbOptions, tag);
+  const relevantVerbOptions = getRelevantVerbOptionsForTag(verbOptions, tag);
 
   const retrievals = relevantVerbOptions.filter((verbOption) =>
     isRetrievalVerb(
@@ -1616,7 +1606,7 @@ export const generateHttpResourceExtraFiles: ClientExtraFilesBuilder = (
 
   return Promise.resolve([
     buildHttpResourceExtraFile(
-      getVerbOptionsRecord(getRelevantVerbOptions(verbOptions)),
+      getVerbOptionsRecord(getRelevantVerbOptionsForTag(verbOptions)),
       getHttpResourceExtraFilePath(output),
       output,
       context,

packages/angular/src/test-helpers.ts

@@ -0,0 +1,17 @@
+import type { GeneratorVerbOptions } from '@orval/core';
+
+/**
+ * Builds a minimal {@link GeneratorVerbOptions.queryParams} object for use in
+ * unit tests. Only the fields required by the Angular generators are populated;
+ * everything else can be overridden via the `overrides` argument.
+ */
+export const createQueryParams = (
+  overrides: Partial<NonNullable<GeneratorVerbOptions['queryParams']>> = {},
+): NonNullable<GeneratorVerbOptions['queryParams']> => ({
+  schema: { name: 'GetPetByIdParams', model: '', imports: [] },
+  deps: [],
+  isOptional: true,
+  originalSchema: { type: 'object' },
+  requiredNullableKeys: [],
+  ...overrides,
+});