Skip to content

fix: remove dead code and unused files#3629

Merged
melloware merged 1 commit into
orval-labs:masterfrom
daugvinasr:cleanup-unused-files
Jun 19, 2026
Merged

fix: remove dead code and unused files#3629
melloware merged 1 commit into
orval-labs:masterfrom
daugvinasr:cleanup-unused-files

Conversation

@daugvinasr

@daugvinasr daugvinasr commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Did some digging and scanning with knip and found unused packages and functions. Decided to do little cleanup.

Summary by CodeRabbit

  • Chores
    • Removed unused dependencies across multiple packages to streamline project dependencies.
    • Consolidated internal implementations by marking several helper functions and type definitions as internal-only, reducing the public API surface.
    • Removed an internal utility module no longer in use.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e4e7d8c-aeef-4c94-8140-621bd9443ce3

📥 Commits

Reviewing files that changed from the base of the PR and between ac14578 and 9eebb12.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (17)
  • package.json
  • packages/core/src/test-utils/split-modes.ts
  • packages/fetch/package.json
  • packages/hono/package.json
  • packages/hono/src/handler-merge.ts
  • packages/mock/src/types.ts
  • packages/orval/package.json
  • packages/orval/src/utils/http-resolver.ts
  • packages/orval/src/utils/index.ts
  • packages/orval/src/utils/options.ts
  • packages/orval/src/utils/package-json.ts
  • packages/orval/src/utils/request.ts
  • packages/query/src/client.ts
  • packages/query/src/dependencies.ts
  • packages/query/src/frameworks/index.ts
  • packages/query/src/utils.ts
  • packages/solid-start/package.json
💤 Files with no reviewable changes (7)
  • packages/orval/src/utils/package-json.ts
  • packages/orval/src/utils/request.ts
  • packages/orval/src/utils/index.ts
  • packages/orval/src/utils/http-resolver.ts
  • packages/orval/package.json
  • package.json
  • packages/query/src/utils.ts

📝 Walkthrough

Walkthrough

Across multiple packages, exported symbols are removed or internalized: generateQueryRequestFunction and five framework predicate helpers are deleted from @orval/query; request.ts, httpResolver, getDefaultFilesHeader, and _resetResolvedCache are removed from @orval/orval; ValidatorTarget and OrvalImport are de-exported in @orval/hono. Corresponding unused package dependencies (esbuild-plugin-alias, remeda, enquirer, @scalar/openapi-types) are removed.

Changes

Export Surface Reduction and Dependency Cleanup

Layer / File(s) Summary
@orval/query public API reduction
packages/query/src/client.ts, packages/query/src/utils.ts, packages/query/src/dependencies.ts, packages/query/src/frameworks/index.ts
Removes exported generateQueryRequestFunction dispatcher, five framework predicate helpers (isVue, isSolid, isAngular, isReact, isSvelte), REACT_DEPENDENCIES, PARAMS_SERIALIZER_DEPENDENCIES, and QueryClientType from the query package's public surface.
@orval/orval utils: remove request module and helpers
packages/orval/src/utils/index.ts, packages/orval/src/utils/options.ts, packages/orval/src/utils/package-json.ts
Deletes the request.ts module (exported Response<T> and request<T>), removes the httpResolver export, de-exports getDefaultFilesHeader, removes the _resetResolvedCache testing helper, and drops the ./request re-export from the utils barrel.
Hono, fetch, mock, and core test-utils de-exports
packages/hono/src/handler-merge.ts, packages/core/src/test-utils/split-modes.ts, packages/mock/src/types.ts
Removes export from ValidatorTarget and OrvalImport in hono's handler-merge, de-exports createSplitModeBuilder in core test-utils, and makes a no-op in-place replacement for MockSchemaRef in mock types.
Package dependency removals
package.json, packages/fetch/package.json, packages/hono/package.json, packages/orval/package.json, packages/solid-start/package.json
Removes esbuild-plugin-alias from root devDependencies; removes @scalar/openapi-types from fetch, remeda from hono, enquirer from orval, and an extra entry from solid-start dependencies.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • melloware

Poem

🐇 Hop, hop, the exports shrink,
Dead code removed without a blink!
No more remeda, no enquirer here,
The bundles lighter — give a cheer!
Less surface means less to maintain,
The rabbit tidies the code terrain. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove dead code and unused files' clearly and specifically summarizes the main change—a cleanup effort to eliminate unused dependencies, functions, types, and files identified by the knip tool.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtypedoc-plugin-coverage@​4.0.2 ⏵ 4.0.3100 +110088 +1583100
Updatedtypedoc-plugin-markdown@​4.11.0 ⏵ 4.12.0100 +110084 +488100
Addedjiti@​2.7.09910010085100

View full report

@melloware melloware added this to the 8.19.0 milestone Jun 19, 2026
@melloware melloware added the enhancement New feature or request label Jun 19, 2026
@melloware melloware merged commit 5e49152 into orval-labs:master Jun 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants