Skip to content

fix: in initFlowUrl carry over login challenge#347

Merged
jonas-jonas merged 2 commits intomainfrom
jonas-jonas/carryLoginChallenge
Feb 5, 2025
Merged

fix: in initFlowUrl carry over login challenge#347
jonas-jonas merged 2 commits intomainfrom
jonas-jonas/carryLoginChallenge

Conversation

@jonas-jonas
Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Jan 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.21%. Comparing base (f3fad4d) to head (d45330a).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
- Coverage   42.43%   42.21%   -0.22%     
==========================================
  Files         136      138       +2     
  Lines        2008     2106      +98     
  Branches      288      313      +25     
==========================================
+ Hits          852      889      +37     
- Misses       1149     1205      +56     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 37.00% <31.35%> (+0.21%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

@jonas-jonas jonas-jonas merged commit 5b61c7b into main Feb 5, 2025
4 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/carryLoginChallenge branch February 5, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant