Skip to content

fix: spacing in auth method list#359

Merged
jonas-jonas merged 4 commits intomainfrom
jonas-jonas/authMethodSpacing2
Feb 26, 2025
Merged

fix: spacing in auth method list#359
jonas-jonas merged 4 commits intomainfrom
jonas-jonas/authMethodSpacing2

Conversation

@jonas-jonas
Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Feb 17, 2025
@jonas-jonas jonas-jonas force-pushed the jonas-jonas/authMethodSpacing2 branch from 696b4a5 to 3bbe84e Compare February 25, 2025 14:21
@jonas-jonas jonas-jonas changed the base branch from jonas-jonas/oidcInMethodPicker to main February 25, 2025 14:22
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (f3fad4d) to head (4ed204c).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   42.43%   50.59%   +8.16%     
==========================================
  Files         136      139       +3     
  Lines        2008     2111     +103     
  Branches      288      313      +25     
==========================================
+ Hits          852     1068     +216     
+ Misses       1149     1031     -118     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 47.36% <42.10%> (+10.57%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

@jonas-jonas jonas-jonas marked this pull request as ready for review February 25, 2025 16:35
@jonas-jonas jonas-jonas merged commit 74bd6b7 into main Feb 26, 2025
14 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/authMethodSpacing2 branch February 26, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant