Skip to content

fix: show possible OIDC connections on login method selector#362

Merged
jonas-jonas merged 16 commits intomainfrom
jonas-jonas/oidcInMethodSelector
Mar 5, 2025
Merged

fix: show possible OIDC connections on login method selector#362
jonas-jonas merged 16 commits intomainfrom
jonas-jonas/oidcInMethodSelector

Conversation

@jonas-jonas
Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Feb 25, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 32 lines in your changes missing coverage. Please review.

Project coverage is 50.47%. Comparing base (f3fad4d) to head (c471b97).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
+ Coverage   42.43%   50.47%   +8.04%     
==========================================
  Files         136      139       +3     
  Lines        2008     2106      +98     
  Branches      288      310      +22     
==========================================
+ Hits          852     1063     +211     
+ Misses       1149     1031     -118     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 47.21% <36.17%> (+10.42%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

case UiNodeInputAttributesTypeEnum.Button:
if (isSocial) {
return <Node.OidcButton attributes={attrs} node={node} />
return null
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Social buttons are handled by a different form (to prevent form validation issues when submitting the oidc button). So here we have to return null, to not render it. Not ideal, but atm the best I could come up with...

@jonas-jonas jonas-jonas merged commit f187dd3 into main Mar 5, 2025
11 of 12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/oidcInMethodSelector branch March 5, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant