docs: oauth2/revoke api fewer parameter as required in doc #3261
docs: oauth2/revoke api fewer parameter as required in doc #3261arjprd wants to merge 2 commits intoory:masterfrom
Conversation
client_id and client_secret are mandatory in token revoke api
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3261 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 123 123
Lines 8845 8845
=======================================
Hits 6793 6793
Misses 1627 1627
Partials 425 425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonas-jonas
left a comment
There was a problem hiding this comment.
Hi! Thanks for your PR. :)
Unfortunately, these files are generated by a generator, so manually changing them does not work, as they will be overridden the next time someone runs the generation.
But, fixing that is easy:
- Go to https://github.com/ory/hydra/blob/master/oauth2/handler.go#L578
- Add
ClientIDandClientSecretto therevokeOAuth2Tokenstruct with the appropriate tags and comments (these are what defines what to generate!) - Run
make sdkin the root of the repository
The last step will update/generate a few other files as well - these are necessary and should be committed, too.
And another note: since the time you opened the PR we updated the Go version to 1.19 in this repository. That introduced a few formatting changes, so please update the state on your branch (rebase or merge) and make sure to run make sdk from a shell that has Go 1.19 active (check via go version) to not introduce formatting issues.
Thanks again for providing this PR! :)
client id and client secret are mandatory in oauth2/revoke api
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments