fix: fosite refresh scope narrowing e2e#3403
Draft
james-d-elliott wants to merge 5 commits intoory:masterfrom
Draft
fix: fosite refresh scope narrowing e2e#3403james-d-elliott wants to merge 5 commits intoory:masterfrom
james-d-elliott wants to merge 5 commits intoory:masterfrom
Conversation
fd4ccdc to
e9a1358
Compare
Codecov Report
@@ Coverage Diff @@
## master #3403 +/- ##
==========================================
- Coverage 76.74% 76.70% -0.04%
==========================================
Files 123 123
Lines 9022 9076 +54
==========================================
+ Hits 6924 6962 +38
- Misses 1657 1672 +15
- Partials 441 442 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of conformance e2e test for the related issues.
Related issue(s)
ory/fosite#696
ory/fosite#718
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
This is my first time working with cypress, and there may be a better way to handle the
refreshTokenBrowserScopeor I may have completely bungled it. The intent is for the flow to get an initial refresh token, narrow the scope, then broaden the scope again.