fix: client command example using v2 option#3943
Merged
aeneasr merged 2 commits intoory:masterfrom Feb 25, 2025
Merged
Conversation
Ryuheeeei
commented
Feb 13, 2025
cmd/cmd_import_client.go
Outdated
| To encrypt an auto-generated OAuth2 Client Secret, use flags ` + "`--pgp-key`" + `, ` + "`--pgp-key-url`" + ` or ` + "`--keybase`" + ` flag, for example: | ||
|
|
||
| {{ .CommandPath }} -n "my app" -g client_credentials -r token -a core,foobar --keybase keybase_username | ||
| hydra create client --name "my app" --grant-types client_credentials --response-type token --scope core,foobar --keybase keybase_username |
Contributor
Author
There was a problem hiding this comment.
This isn't hydra import client command. Instead, it seems hydra create client, right ?
According to https://www.ory.sh/docs/hydra/cli/hydra-import-client, it seems hydra create client. Sorry if I misunderstood.
Member
There was a problem hiding this comment.
The CommandPath variable automatically sets the correct name for the help command, so the previous version was correct :)
Contributor
Author
There was a problem hiding this comment.
Thank you!
I reverted this change. 2099fad
9879f21 to
2099fad
Compare
aeneasr
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The examples of these three commands are based on hydra v1 cli option.
hydra create clienthydra import clienthydra update clientWhen I follow the examples using hydra v2 cli, it didn't work. I got the message like
unknown shorthand flag: 'n' in -n.I updated these three commands example using v2 option.
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
Since this is my first time to submit pr to this repo, please tell me if I missed anything.