Skip to content

fix: allow updating when JWKS URI is set (#3935)#3946

Merged
aeneasr merged 1 commit intoory:masterfrom
phooijenga:fix-client-jwks-validator
Feb 25, 2025
Merged

fix: allow updating when JWKS URI is set (#3935)#3946
aeneasr merged 1 commit intoory:masterfrom
phooijenga:fix-client-jwks-validator

Conversation

@phooijenga
Copy link
Copy Markdown
Contributor

The validator rejects updates when JSONWebKeysURI is non-empty and JSONWebKeys is not nil, but this field is set to new(x.JoseJSONWebKeySet) in Client's BeforeSave.

Related issue(s)

#3935

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@phooijenga phooijenga requested review from a team and aeneasr as code owners February 17, 2025 20:54
@phooijenga phooijenga changed the title Allow updating when JWKS URI is set (#3935) feat: allow updating when JWKS URI is set (#3935) Feb 18, 2025
@phooijenga phooijenga changed the title feat: allow updating when JWKS URI is set (#3935) fix(client): allow updating when JWKS URI is set (#3935) Feb 18, 2025
@phooijenga phooijenga changed the title fix(client): allow updating when JWKS URI is set (#3935) fix: allow updating when JWKS URI is set (#3935) Feb 18, 2025
Copy link
Copy Markdown
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit fb1655b into ory:master Feb 25, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants