fix: remove stale reference to closed PR #3851#4082
Open
raajheshkannaa wants to merge 1 commit intoory:masterfrom
Open
fix: remove stale reference to closed PR #3851#4082raajheshkannaa wants to merge 1 commit intoory:masterfrom
raajheshkannaa wants to merge 1 commit intoory:masterfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes dead link to closed PR #3851 discussion from
oauth2/handler.go. The Device Authorization Grant (RFC 8628) feature was later merged via PR #3912, making the reference to #3851 stale. The explanatory comment about the race condition is preserved.Closes #3953
Note on #3996
Issue #3996 reports stale references to
ory/x#509in 146 SQL migration files. However, PR #509 in ory/x was merged (not abandoned) on 2022-05-17. The Closed Reference Notifier bot filed #3996 as a false positive since GitHub treats merged PRs as "closed". Additionally, the migration files are auto-generated and markedDO NOT EDIT. I recommend closing #3996 as not actionable.Test plan