fix: support space-separated OIDC prompt parameter values#4083
Open
raajheshkannaa wants to merge 1 commit intoory:masterfrom
Open
fix: support space-separated OIDC prompt parameter values#4083raajheshkannaa wants to merge 1 commit intoory:masterfrom
raajheshkannaa wants to merge 1 commit intoory:masterfrom
Conversation
The OIDC spec allows multiple prompt values separated by spaces (e.g. "select_account consent"). The validator already handled this correctly by splitting on spaces, but GenerateIDToken in strategy_jwt.go used a switch statement on the raw unsplit string, causing prompt values like "login consent" to skip login-specific validation. Split the prompt parameter by space in GenerateIDToken and use slices.Contains to check for individual values, consistent with how the validator and consent strategy already handle it. Fixes ory#4039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4039
promptas a space-separated list of valuesselect_account consentslices.Containsto check for each recognized value