fix(oidc): return registration_client_uri in PUT and GET dynamic client responses#4090
Open
Yanhu007 wants to merge 1 commit intoory:masterfrom
Open
fix(oidc): return registration_client_uri in PUT and GET dynamic client responses#4090Yanhu007 wants to merge 1 commit intoory:masterfrom
Yanhu007 wants to merge 1 commit intoory:masterfrom
Conversation
…nt responses The OIDC Dynamic Client Registration PUT and GET endpoints do not include registration_client_uri in their responses, violating the OpenID Connect Dynamic Client Registration 1.0 specification. The POST (create) endpoint correctly sets RegistrationClientURI, but the PUT (update) and GET (read) endpoints omit it. Set RegistrationClientURI before writing the response in both setOidcDynamicClient and getOidcDynamicClient, matching the create handler's behavior. Fixes ory#4084
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4084
Problem
The OIDC Dynamic Client Registration
PUTandGETendpoints do not includeregistration_client_uriin their responses, violating the OpenID Connect Dynamic Client Registration 1.0 specification.The
POST(create) endpoint correctly sets it (handler.go:199), butPUT(update) andGET(read) omit it.Fix
Set
RegistrationClientURIbefore writing the response in bothsetOidcDynamicClientandgetOidcDynamicClient, matching the create handler.