feat: add service policies to values#815
Merged
Demonsthere merged 16 commits intoory:masterfrom Oct 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configurable traffic policy settings to Kubernetes services across multiple Helm charts, allowing users to specify externalTrafficPolicy and internalTrafficPolicy for their services. Additionally, it updates the version references for oathkeeper-maester and hydra-maester components.
- Adds
externalTrafficPolicyandinternalTrafficPolicyconfiguration options to all service definitions with default value of "Cluster" - Updates
oathkeeper-maesterfrom v0.1.11 to v0.1.12 - Updates
hydra-maesterfrom v0.0.39 to v0.0.40
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/charts/oathkeeper/values.yaml | Adds traffic policy configurations to proxy, api, and metrics services |
| helm/charts/oathkeeper/templates/service-*.yaml | Applies traffic policy template variables to service specs |
| helm/charts/oathkeeper/README.md | Documents new traffic policy options and updates maester version reference |
| helm/charts/oathkeeper-maester/README.md | Updates AppVersion badge from v0.1.11 to v0.1.12 |
| helm/charts/kratos/values.yaml | Adds traffic policy configurations to admin, public, and courier services |
| helm/charts/kratos/templates/service-*.yaml | Applies traffic policy template variables to service specs |
| helm/charts/kratos/README.md | Documents new traffic policy options for all kratos services |
| helm/charts/kratos-selfservice-ui-node/values.yaml | Adds traffic policy configurations to the service |
| helm/charts/kratos-selfservice-ui-node/templates/service.yaml | Applies traffic policy template variables to service spec |
| helm/charts/kratos-selfservice-ui-node/README.md | Documents new traffic policy options |
| helm/charts/keto/values.yaml | Adds traffic policy configurations to read, write, and metrics services |
| helm/charts/keto/templates/service-*.yaml | Applies traffic policy template variables to service specs |
| helm/charts/keto/README.md | Documents new traffic policy options for all keto services |
| helm/charts/hydra/values.yaml | Adds traffic policy configurations to public and admin services |
| helm/charts/hydra/templates/service-*.yaml | Applies traffic policy template variables to service specs |
| helm/charts/hydra/README.md | Documents new traffic policy options for hydra services |
| helm/charts/hydra-maester/values.yaml | Adds traffic policy configurations to metrics service |
| helm/charts/hydra-maester/templates/service-metrics.yaml | Applies traffic policy template variables to service spec |
| helm/charts/hydra-maester/README.md | Documents new traffic policy options and updates AppVersion badge from v0.0.39 to v0.0.40 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments