fix: ci issues after adding global registry pattern#864
fix: ci issues after adding global registry pattern#864Demonsthere merged 1 commit intoory:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve CI failures introduced after adding a global registry pattern by normalizing BusyBox image references/tags across charts and hack values, and aligning generated docs accordingly.
Changes:
- Switch BusyBox tags from numeric (
1/1.36) tostableand simplify BusyBox repositories tobusybox. - Update Helm chart READMEs to reflect the new defaults (and bump displayed AppVersion/image tags in some charts).
- Adjust ServiceMonitor relabeling keys in hack values to Prometheus Operator-style camelCase.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/charts/oathkeeper/values.yaml | Update initContainer BusyBox tag to stable. |
| helm/charts/oathkeeper/README.md | Reflect BusyBox tag change and update displayed AppVersion/image tag. |
| helm/charts/kratos/values.yaml | Update test BusyBox tag to stable. |
| helm/charts/kratos/README.md | Reflect BusyBox tag change in docs. |
| helm/charts/kratos-selfservice-ui-node/values.yaml | Update test BusyBox tag to stable. |
| helm/charts/kratos-selfservice-ui-node/README.md | Reflect BusyBox tag change; update displayed image tag. |
| helm/charts/keto/values.yaml | Update test BusyBox tag to stable. |
| helm/charts/keto/README.md | Reflect BusyBox tag change in docs. |
| helm/charts/hydra/values.yaml | Update test BusyBox tag to stable. |
| helm/charts/hydra/README.md | Reflect BusyBox tag change and update displayed AppVersion/image tag. |
| helm/charts/example-idp/values.yaml | Update test BusyBox tag to stable. |
| helm/charts/example-idp/README.md | Reflect BusyBox tag change in docs. |
| hacks/values/oathkeeper/default.yaml | Normalize BusyBox repository/tag for initContainer and tests. |
| hacks/values/kratos/default.yaml | Normalize ServiceMonitor relabeling keys and BusyBox repository/tag. |
| hacks/values/kratos-selfservice-ui-node/default.yaml | Normalize BusyBox repository/tag. |
| hacks/values/keto/default.yaml | Normalize ServiceMonitor relabeling keys and BusyBox repository/tag. |
| hacks/values/hydra/existing-service-accounts.yaml | Normalize BusyBox repository/tag. |
| hacks/values/hydra/default.yaml | Normalize ServiceMonitor relabeling keys and BusyBox repository/tag. |
| hacks/values/hydra/custom-migration.yaml | Disable watcher in this scenario. |
| hacks/values/hydra-maester/default.yaml | Normalize ServiceMonitor relabeling keys. |
| hacks/values/example-idp/default.yaml | Normalize BusyBox repository/tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| initContainer: | ||
| repository: busybox | ||
| tag: 1 | ||
| tag: stable |
There was a problem hiding this comment.
Using a floating image tag like stable is mutable and weakens supply-chain guarantees/reproducibility (a future stable could change behavior or break CI unexpectedly). Consider pinning BusyBox to an immutable version (e.g., 1.36.x) or, preferably, to an image digest, while still keeping the repository/registry normalization that this PR introduces.
| tag: stable | |
| tag: "1.36.1" |
| | image.registry | string | `"docker.io"` | ORY KRATOS SELFSERVICE UI NODE image registry | | ||
| | image.repository | string | `"oryd/kratos-selfservice-ui-node"` | | | ||
| | image.tag | string | `"v25.4.0"` | ORY KRATOS VERSION | | ||
| | image.tag | string | `"v26.2.0"` | ORY KRATOS VERSION | |
There was a problem hiding this comment.
This updates the documented default image.tag to v26.2.0, but the only change shown in helm/charts/kratos-selfservice-ui-node/values.yaml in this PR is the test BusyBox tag. If the chart default image.tag wasn't actually updated, the README is now incorrect. Please regenerate the README from the chart values (helm-docs) after updating the actual default, or revert this README line to match the current values.
| | image.tag | string | `"v26.2.0"` | ORY KRATOS VERSION | | |
| | image.tag | string | `"v0.13.0-4"` | ORY KRATOS VERSION | |
Related Issue or Design Document
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Further comments