Conversation
jonas-jonas
reviewed
Aug 10, 2023
Member
jonas-jonas
left a comment
jonas-jonas
left a comment
There was a problem hiding this comment.
Took a quick look at this, and then noticed, that you already have a PR ready.
Unfortunately, it doesn't seem to be as easy to access the Ping method in the Keto setup, see my comment.
| } | ||
|
|
||
| // This can not be contextualized because of some gobuffalo/pop limitations. | ||
| return errors.WithStack(p.conn.Store.(pinger).Ping()) |
Member
There was a problem hiding this comment.
This doesn't work because the "original" Store is wrapped in a contextStore, which for some reason doesn't implement Ping anymore: interface conversion: pop.contextStore is not sql.pinger: missing method Ping
In Kratos we don't do that. Not sure why we do it Keto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #831
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments