fix: update verification UI to support sms code verification alongside email #4384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aran
changed the title
aran
commented
Apr 17, 2025
|
Thanks for your work on this! |
…e email To keep scope as small as possible: * Does not update the 'link' method * Does not fix similar issues in recovery * Does not dynamically check the schema to optimize the UI
…update a related comment
…lusive of non-email methods
…rificationMessageWithCodeSent message
The implementation up to now unblocks using SMS verification, but it had the downside of always adding phone fields to verification unconditionally. (The previous implementation added the email field unconditionally.) This commit makes the verification fields conditional on the schema.
|
Thanks for the work here. Would be great to see a fix like this in sometime soon! |
|
@robert-baldwin FYI https://ory-community.slack.com/archives/C012USDT5QQ/p1745307840014349 In the meantime you can use https://github.com/aran/kratos/tree/integration-2025-04-22 as a temporary hack if you have infrastructure to build containers from source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Update verification UI to support sms code verification alongside email
Related issue(s)
#4197
#406
#4161
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
See also individual commit comments.
To keep scope as small as possible:
* Does not update the 'link' method
* Does not fix similar issues in recovery
Includes a couple relevant small naming refactors, updates to the id_test, and a small related copy change. The basic principle of when to leave "email" alone vs. updating to be more general was based on whether it is exposed to the client or internal and private to the codebase. e.g. StateEmailSent is left untouched.