fix: clean up stale custom domains before acceptance test#149
Merged
Conversation
The custom domain acceptance test fails with "Duplicate custom hostname found (1406)" when a previous test run failed before its destroy step could clean up the CNAME. Add a pre-test cleanup that deletes any existing custom domains from the test project before creating new ones.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a pre-check cleanup step for custom domain acceptance tests to prevent failures caused by leftover (stale) custom domains from interrupted prior runs.
Changes:
- Introduce
cleanupStaleCustomDomains()helper to delete existing custom domains in the test project. - Call the cleanup helper from
testAccPreCheckCustomDomain.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Demonsthere
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add pre-test cleanup for custom domain acceptance tests. When a previous test run fails mid-step, the custom domain CNAME is left on the smoke test project, causing subsequent runs to fail with "Duplicate custom hostname found (1406)".
The
cleanupStaleCustomDomains()function runs duringPreCheckand deletes any existing custom domains from the test project before the test creates new ones.Related Issues
closes #148
Type of Change
Checklist
make test)make format)Testing
Acceptance test output