Skip to content

ci: added concurrency for tests + lint and format#4

Merged
KT-Doan merged 15 commits intomainfrom
feat/staging-gitflow
Feb 2, 2026
Merged

ci: added concurrency for tests + lint and format#4
KT-Doan merged 15 commits intomainfrom
feat/staging-gitflow

Conversation

@KT-Doan
Copy link
Copy Markdown
Collaborator

@KT-Doan KT-Doan commented Jan 26, 2026

Description

Removed concurrency for acceptance tests as the staging environment will fail if there are multiple tests running at once.

Added lint + formatting + PR conventional commits.

Related Issues

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • I have read the CONTRIBUTING guide
  • My code follows the existing code style
  • I have added tests that prove my fix/feature works
  • I have updated documentation as needed
  • All new and existing tests pass (make test)
  • I have run the linter (make format)

Testing

Describe how you tested these changes:

  • Unit tests
  • Acceptance tests
  • Manual testing

Screenshots/Output

If applicable, add screenshots or command output to help explain your changes.

@KT-Doan KT-Doan self-assigned this Jan 26, 2026
@KT-Doan KT-Doan changed the title feat: added concurrency for tests so testing environment doesn't conflict feat: added concurrency for tests + lint and format Jan 26, 2026
@KT-Doan KT-Doan changed the title feat: added concurrency for tests + lint and format ci: added concurrency for tests + lint and format Jan 26, 2026
@KT-Doan
Copy link
Copy Markdown
Collaborator Author

KT-Doan commented Jan 26, 2026

// Try to extract the error body from GenericOpenAPIError
var bodyStr string
if apiErr, isAPIErr := err.(*ory.GenericOpenAPIError); isAPIErr {
var apiErr *ory.GenericOpenAPIError
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in such cases you can use https://pkg.go.dev/k8s.io/utils/ptr#To 😉

@KT-Doan KT-Doan merged commit 0df468a into main Feb 2, 2026
5 checks passed
@KT-Doan KT-Doan deleted the feat/staging-gitflow branch February 2, 2026 08:46
KT-Doan added a commit that referenced this pull request Mar 4, 2026
ci: added concurrency for tests + lint and format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants