-
Notifications
You must be signed in to change notification settings - Fork 296
Add tests for docker-py & podman-py #23045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for docker-py & podman-py #23045
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
e7687a9 to
48730a9
Compare
9de37d7 to
3c1cb31
Compare
39e23ec to
ace1c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty long. I wonder if it really makes sense to keep docker&podman together here.
There's no need to review the backported fixes. Only the new module and the scheduling. Splitting would be a mess because they share common code. |
Add tests for python3-docker & python3-podman.
This brings lots of benefits:
These tests take only ~7 minutes.
TODO (in another PR):
git apply -3 --oursso a special repo is needed like we do with BATS tests.Verification runs:
Using GIT_REPO: https://openqa.opensuse.org/tests/5258587