Automate enable kdump for agama installation #23746
Open
+68
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjluo
changed the title
hjluo
force-pushed
the
agama_kdump
branch
10 times, most recently
from
13e43cb to
26df2f9
Compare
hjluo
changed the title
hjluo
changed the title
jknphy
reviewed
Nov 12, 2025
hjluo
force-pushed
the
agama_kdump
branch
14 times, most recently
from
6e520e8 to
be5168b
Compare
hjluo
force-pushed
the
agama_kdump
branch
9 times, most recently
from
2bedb65 to
bc7c142
Compare
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
jknphy
reviewed
Dec 8, 2025
hjluo
force-pushed
the
agama_kdump
branch
6 times, most recently
from
7c0ff5c to
1a7b159
Compare
hjluo
changed the title
jknphy
reviewed
Dec 9, 2025
tests/yam/validate/validate_kdump.pm
Outdated
| my ($self) = @_; | ||
| select_console 'root-console'; | ||
|
|
||
| systemctl("is-active kdump.service", ignore_failure => 1); |
Contributor
There was a problem hiding this comment.
does it really ignore failure? it should fail if the service is not as expected.
jknphy
reviewed
Dec 9, 2025
tests/yam/validate/validate_kdump.pm
Outdated
Comment on lines
28
to
32
| if (is_s390x()) { | ||
| power_action('reboot', textmode => 1); | ||
| } else { | ||
| power_action('reboot', keepconsole => 1, textmode => 1); | ||
| } |
Contributor
There was a problem hiding this comment.
Something like this could work and it is much shorter (not tested):
power_action('reboot', is_s390x ? () : keepconsole => 1, textmode => 1);
hjluo
force-pushed
the
agama_kdump
branch
2 times, most recently
from
1d0669d to
00034ba
Compare
- Automate enable Kdump for agama installation - Related ticket: rogress.opensuse.org/issues/189150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automate enabling kdump since first boot from Agama profile