-
Notifications
You must be signed in to change notification settings - Fork 26
PART 1: Add dependencies for modern Python development #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
okurz
commented
Jan 8, 2026
- feat(ci): Simplify deps setup with uv
- feat(pyproject.toml): Add config for proper python package paths
- feat(Makefile): Add more Python related targets using "uv"
- feat(pyproject.toml): Add dependencies in preparation for typecheck+maintainability checks
- feat(pyproject.toml): Enable dependencies for modern scripts (typer+httpx)
- fix(test_trigger_bisect_jobs): fix "path" style issue
d914509 to
e392ac5
Compare
Martchus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these dependencies already required? If not I wouldn't separate adding them from the actual changes requiring them.
| - uses: astral-sh/setup-uv@v7 | ||
| with: | ||
| enable-cache: true | ||
| - run: uv sync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to find also uv.lock in the repo. otherwise what the us is syncing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same is in https://github.com/openSUSE/qem-bot/blob/master/.github/workflows/ci.yml#L22 this installs all necessary dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which also doesnt have a uv.lock. which means that it creates a new one each time is run likely. Both repos should contain the uv.lock. Then the ci should see this and run exactly the same as you run in your workstation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so as well, uv.lock is necessary for reproducible Python environments.
the dependencies would only be required in #499 |
Martchus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I say we should add the dependencies only as needed. At least for me it makes no sense to approve this independently from the actual code that I haven't looked at.