-
Notifications
You must be signed in to change notification settings - Fork 3
Power and Thermal Specification for RPE - Front end (updated) #TODO #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power and Thermal Specification for RPE - Front end (updated) #TODO #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
+ Coverage 68.78% 70.40% +1.62%
==========================================
Files 110 55 -55
Lines 9035 7026 -2009
Branches 402 0 -402
==========================================
- Hits 6215 4947 -1268
+ Misses 2820 2079 -741 ☔ View full report in Codecov by Sentry. |
@chernyee please pull this branch and please test once, this should have the changes we discussed yesterday, we can discuss this once you are online. |
function PowerSummaryTable({ | ||
title, data, total, percent, | ||
title, data = [], total = 0, percent = 0, deviceId = 'MPW1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't hardcode this, it should be reading this from the selected device option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay, right , this shall be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not resolved, please look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ravikiranchollangi , this is a delicate feature, it would be time consuming to do these changes, I shall do it, but can we push it for MPW1 for this release for time being? We have one device for now, so it works on itself.
The feature works now and I connected with @chernyee yesterday offline and he gave a thumbs up to the front end changes, just this hardcoding thing shall be taken care of in some time.
@ravikiranchollangi we can put this feature now is what I feel, please do let me know what you think and please merge it if everything looks ok.
Feature: tested and verified it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more comment
PR for Power and Thermal Specification block, the front end is ready, CSS has been taken care of, updated the GlobalStateProvider.js of these files, so it deals good with the backend, everything looks ok.
Intitial look of the feature:
When the user inputs are changed for Power and Thermal Specification: