test legacy virtv2v migration with CI#133
Merged
cloudguruab merged 6 commits intoos-migrate:mainfrom Nov 14, 2025
Merged
Conversation
Contributor
Author
|
Testing with 17.1 |
dc29a1f to
8e1a739
Compare
8e1a739 to
35f4696
Compare
matbu
reviewed
Nov 14, 2025
Contributor
matbu
left a comment
There was a problem hiding this comment.
LGTM overall, but I think we need to fix the find command:
https://github.com/os-migrate/vmware-migration-kit/blob/main/roles/import_workloads/tasks/virt_v2v.yml#L5
When I commit into your branch, I commited the fix for this step. If you can add it too, so we have a fully working v2v way.
Contributor
|
This command should work: |
Contributor
Author
|
Will fix ansible lint checks after successful CI run 👍🏼 |
matbu
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes virt-v2v authentication with vCenter users containing @ symbols.
Enables customers to reproduce virt-v2v bugs using the legacy workflow.