Skip to content

test legacy virtv2v migration with CI#133

Merged
cloudguruab merged 6 commits intoos-migrate:mainfrom
cloudguruab:test-virtv2v
Nov 14, 2025
Merged

test legacy virtv2v migration with CI#133
cloudguruab merged 6 commits intoos-migrate:mainfrom
cloudguruab:test-virtv2v

Conversation

@cloudguruab
Copy link
Copy Markdown
Contributor

@cloudguruab cloudguruab commented Nov 12, 2025

Summary

  • Change connection URI from esx:// to vpx:// for vCenter
  • URL-encode @ symbol in vCenter usernames
  • Update virt_v2v.yml to use proper variables instead of hardcoded values
  • Update unit tests to reflect new URI format

Fixes virt-v2v authentication with vCenter users containing @ symbols.
Enables customers to reproduce virt-v2v bugs using the legacy workflow.

@cloudguruab
Copy link
Copy Markdown
Contributor Author

Testing with 17.1

Copy link
Copy Markdown
Contributor

@matbu matbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but I think we need to fix the find command:
https://github.com/os-migrate/vmware-migration-kit/blob/main/roles/import_workloads/tasks/virt_v2v.yml#L5

When I commit into your branch, I commited the fix for this step. If you can add it too, so we have a fully working v2v way.

@matbu
Copy link
Copy Markdown
Contributor

matbu commented Nov 14, 2025

This command should work:
set -o pipefail
find / -path /usr/share/doc -prune -o -name vmware-vix-disklib -print 2>/dev/null | xargs -r dirname | sort -u

@cloudguruab
Copy link
Copy Markdown
Contributor Author

Will fix ansible lint checks after successful CI run 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants