Fixed date issue with calendar test #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turegjorup
requested changes
Apr 4, 2025
cypress/component/Calendar.cy.js
Outdated
| cy.clock(); | ||
| cy.tick(timestamp); | ||
|
|
||
| const now = new Date(timestamp); |
There was a problem hiding this comment.
Please use a more descriptive name than now, either mockNow, mockTestDate or something even better.
cypress/component/Calendar.cy.js
Outdated
| }); | ||
|
|
||
| it("Calendar multiple days", () => { | ||
| const timestamp = 60 * 60 * 1000 * 8; |
There was a problem hiding this comment.
Add comment explaining the choice of math :-)
Consider changing timestamp to a more descriptive name
cypress/component/Calendar.cy.js
Outdated
| }); | ||
|
|
||
| it("Calendar multiple", () => { | ||
| const timestamp = 60 * 60 * 1000 * 8; |
There was a problem hiding this comment.
Also. Is it necessary to duplicate code?
cypress/component/Calendar.cy.js
Outdated
| @@ -682,6 +745,13 @@ describe("Calendar", () => { | |||
| }); | |||
|
|
|||
| it("Calendar single", () => { | |||
| const timestamp = 60 * 60 * 1000 * 8; | |||
turegjorup
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/4084
Description
Fixed date issue with calendar test
Checklist