i18n(zh): fill missing zh-Hans/zh-Hant strings for Media settings and welcome prompts - #2623
Open
thedavidweng wants to merge 1 commit into
Open
i18n(zh): fill missing zh-Hans/zh-Hant strings for Media settings and welcome prompts#2623thedavidweng wants to merge 1 commit into
thedavidweng wants to merge 1 commit into
Conversation
… welcome prompts Keys referenced via L()/LocalizedStringKey but missing from the catalog or left as empty stubs silently fell back to English: - Media tab: Media title, header subtitle (+ %lld variant), Image/Text-to-video/Image-to-video generation model rows, Video Jobs section, Venice hint, empty-state strings - Welcome screen: What can Osaurus do? / Create an agent chips (labels and the prompts they send) zh-Hans/zh-Hant translated; de/ko/ru/es/ja left as needs_review English fallback per repo convention. Validated with bash scripts/i18n/check.sh (coverage, Swift-key cross-check, literal lint all pass).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fills zh-Hans/zh-Hant translations for UI strings that were referenced in code but missing from
Packages/OsaurusCore/Resources/Localizable.xcstrings(absent keys or empty stubs), so they silently fell back to English on a Chinese system language. Follow-up discussion issues: #2621 (Thinking key split), #2622 (CI visibility for untranslated keys).Changes
Single-file change, translation data only, no Swift touched:
Mediatitle, header subtitle (+%lldon-device variant),Image generation model/Text-to-video model/Image-to-video modelrows,Video Jobssection (title, blurb, permission hint), Venice hint, empty-state stringsWhat can Osaurus do?andCreate an agentquick-action chips, including the prompts they sendneeds_reviewfallback per repo convention socheck.shstays greenTest Plan
(stale-key warnings are pre-existing: 869 / 1, untouched by this PR).
Manual: set system language to Simplified/Traditional Chinese, open Settings → Media and the welcome screen, confirm no English remnants in the listed rows.
Screenshots
Before: Media settings showed English subtitle +
Image generation model/Text-to-video model/Image-to-video modelrows andMediatitle; welcome screen showed EnglishWhat can Osaurus do?/Create an agentchips (reported with screenshots). After: all listed strings render in Chinese. After-screenshots to be attached on request (string-only change, verified via catalog + preview).Checklist
CONTRIBUTING.mdscripts/i18n/check.shcoverage + Swift-key cross-check + literal lint, all passing)