minor performance updates - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While investigating #47 , I noticed minor optimization to be had for Swift Jinja package.
Related PRs:
huggingface/swift-jinja#24
huggingface/swift-transformers#226
Before:
After:
Although the benchmark performance seems very minor (maybe 3% closer to LM Studio), Jinja optimization should have lasting effects beyond the benchmarks.
I will be getting back to the drawing board to find some other areas for improvements. ✏️
Changes
Checklist
CONTRIBUTING.md