Skip to content

[codex] Fix PocketTTS language initialization#977

Closed
mimeding wants to merge 1 commit intoosaurus-ai:feat/tts-supportfrom
mimeding:codex/fix-tts-fluidaudio-language
Closed

[codex] Fix PocketTTS language initialization#977
mimeding wants to merge 1 commit intoosaurus-ai:feat/tts-supportfrom
mimeding:codex/fix-tts-fluidaudio-language

Conversation

@mimeding
Copy link
Copy Markdown
Contributor

Summary

  • pass FluidAudio PocketTTS language into model download initialization
  • align PocketTTS cache detection with the v2/english language-pack directory
  • keep manager initialization explicit about the selected language

Why

The TTS branch no longer compiles against the current FluidAudio API because PocketTtsResourceDownloader.ensureModels now requires a language argument.

Verification

  • swiftlint --strict Packages/OsaurusCore/Managers/TTSService.swift
  • swift test --filter ChatViewSandboxTests/prepareChatExecutionMode_usesSessionAgentInsteadOfActiveAgent

@mimeding mimeding mentioned this pull request Apr 29, 2026
9 tasks
@mimeding
Copy link
Copy Markdown
Contributor Author

Follow-up from the live debug pass: the FluidAudio/PocketTTS compatibility fix verifies locally against the TTS branch.

Local checks:

  • swiftlint --strict Packages/OsaurusCore/Managers/TTSService.swift passed.
  • swift test --filter ChatViewSandboxTests/prepareChatExecutionMode_usesSessionAgentInsteadOfActiveAgent passed after compiling the branch.

GitHub test-core is currently failing before tests execute with the same EventSource module-resolution issue (CAsyncHTTPClient, CNIOLLHTTP, CNIOExtrasZlib, CNIOPosix, _NumericsShims). That is the shared CI failure addressed by #975, not a new TTS failure. Recommended order: land #975, rerun #977, then use this as the narrow unblocker for #962.

@mimeding
Copy link
Copy Markdown
Contributor Author

Status update after adding the clean-PR rule: this companion PR is now draft because its attached GitHub checks are not clean yet. It should move back to ready only after the shared CI fix in #975 lands/rebases into the branch and scripts/ci/check-pr-clean.sh osaurus-ai/osaurus 977 passes.

@RaajeevChandran RaajeevChandran deleted the branch osaurus-ai:feat/tts-support April 30, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants