-
Notifications
You must be signed in to change notification settings - Fork 84
Automotive initial work #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automotive initial work #928
Conversation
bcd420b
to
d5f7e45
Compare
I'm not sure what exactly is going wrong in the tests, but my guess is that it is caused by the verity change. I'm gonna try reverting that for now. |
ff9f4a6
to
8e12982
Compare
The CI failure is:
Which doesn't seem related to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far. Holding off until images PR is merged.
One note about commit messages: Can you amend commit message to follow the preferred format?
Thanks!
It seems there's a bunch of stuff failing in that dracut stage. Yes, it's unrelated. I'll look into it. |
Opened #929 to update the images dependency to the latest release. I suspect something might have changed that is causing these issues. Either that, or it's a package / dracut module change (again). Either way, it should show up there and if not it'll minimise the changes being pulled into this PR. |
8e12982
to
29cde77
Compare
I rebased this with some changes, and fixes to the commit messages. |
#929 fixed the dracut stage issue and got merged. |
29cde77
to
63c6937
Compare
@achilleas-k Cool, i rebased on master, lets see if it passes CI now. |
df56bbd
to
25ef903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Tentative LGTM (pending images PR merge).
It's failing this:
Which may be related to this change actually. |
No, this seems to be some package issue, it seems to have the right arguments to the selinux labeling stage:
But then it reports errors loading this policy:
And later we see the result of this causing labeling to not be correct:
|
25ef903
to
4e5681f
Compare
Ok, new version that is rebased on latest, now using the osbuild/images commit with the merged PR. |
Note: I'm not sure what the policy is on depending on a non-versioned osbuild/image commit id like this. We should maybe do a osbuild/images release first. But if so, I would like osbuild/images#1543 to land first, as I want to use that with bc-i-b too. |
4e5681f
to
c785c4a
Compare
CI is failing with out of disk errors when building some test container image:
|
arch.FromString can now return an error
Currently we are always hardcoding "targeted", which is not working for the centos automotive sig that use a custom policy.
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
This rewrites the partition table after creation so that it works both with filesystem and disk customizations.
c785c4a
to
ac75d33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This is some initial work for supporting bootc in the automotive projects. It includes the following:
This depends on: osbuild/images#1519