Automotive initial work #928
Conversation
alexlarsson
force-pushed
the
automotive-initial-work
branch
from
bcd420b to
d5f7e45
Compare
|
I'm not sure what exactly is going wrong in the tests, but my guess is that it is caused by the verity change. I'm gonna try reverting that for now. |
alexlarsson
force-pushed
the
automotive-initial-work
branch
3 times, most recently
from
ff9f4a6 to
8e12982
Compare
|
The CI failure is:
Which doesn't seem related to this change. |
There was a problem hiding this comment.
LGTM so far. Holding off until images PR is merged.
One note about commit messages: Can you amend commit message to follow the preferred format?
Thanks!
| f, err := os.Open(path.Join(root, configPath)) | ||
| if err != nil { | ||
| return "", fmt.Errorf("cannot read selinux config %s: %w", configPath, err) | ||
| } |
There was a problem hiding this comment.
The file isn't explicitly closed.
It seems there's a bunch of stuff failing in that dracut stage. Yes, it's unrelated. I'll look into it. |
|
Opened #929 to update the images dependency to the latest release. I suspect something might have changed that is causing these issues. Either that, or it's a package / dracut module change (again). Either way, it should show up there and if not it'll minimise the changes being pulled into this PR. |
alexlarsson
force-pushed
the
automotive-initial-work
branch
from
8e12982 to
29cde77
Compare
|
I rebased this with some changes, and fixes to the commit messages. |
|
#929 fixed the dracut stage issue and got merged. |
alexlarsson
force-pushed
the
automotive-initial-work
branch
from
29cde77 to
63c6937
Compare
|
@achilleas-k Cool, i rebased on master, lets see if it passes CI now. |
alexlarsson
force-pushed
the
automotive-initial-work
branch
from
63c6937 to
df56bbd
Compare
Currently we are always hardcoding "targeted", which is not working for the centos automotive sig that use a custom policy.
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
This rewrites the partition table after creation so that it works both with filesystem and disk customizations.
arch.FromString can now return an error
This makes us able to use the new API changes from osbuild/images#1526
alexlarsson
force-pushed
the
automotive-initial-work
branch
from
df56bbd to
25ef903
Compare
This is some initial work for supporting bootc in the automotive projects. It includes the following:
This depends on: osbuild/images#1519