Extract output subslice from wizard store

[kingsleyzissou]

Extract output subslice from wizard store

Summary

Extracts the output subdomain (image types, architecture, distribution) from the monolithic wizard slice into a dedicated subslice, following the same pattern established by compliance, details, and filesystem. This reduces the size of the wizard slice and co-locates output-related types, selectors, typeguards, constants, and tests.

Changes

• Extract output types, constants, initial state, selectors, reducers, and typeguards into store/slices/wizard/output/ with a barrel re-export
• Move inline listener side-effects (filterImageTypes, registerLater) from store/index.ts into store/middleware/ and slices/wizard/listeners.ts, deduplicating the previously copy-pasted filterImageTypes logic for changeArchitecture and changeDistribution
• Upgrade isRhel from a plain boolean function to a type predicate (distro is RhelDistribution) and add isPublicCloud/isPrivateCloud predicates, replacing inline Set.has() checks in useTargetEnvironmentCategories
• Add unit tests for the new typeguards, both listener effects, and the loadWizardState fallback for blueprints serialised before the subslice existed
• Add ESLint no-restricted-imports rule for output/* internals to enforce barrel discipline

[kingsleyzissou]

These are all pretty mechanical changes. The only super new thing is adding listeners for some of the changes and moving where those live

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The test helpers for listener effects (e.g. the createListenerApi implementations in filterImageTypes.test.ts and registerLater.test.ts) are nearly identical; consider extracting a shared factory into a common test utility to reduce duplication and keep listener tests consistent.
• In listeners.ts, filterImageTypes currently casts the RootState to any when calling backendApi.endpoints.getArchitectures.select; if possible, tightening this typing (e.g. via a discriminated union or a typed wrapper around backendApi) would avoid the escape hatch and make the middleware safer to refactor.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The test helpers for listener effects (e.g. the `createListenerApi` implementations in `filterImageTypes.test.ts` and `registerLater.test.ts`) are nearly identical; consider extracting a shared factory into a common test utility to reduce duplication and keep listener tests consistent.
- In `listeners.ts`, `filterImageTypes` currently casts the RootState to `any` when calling `backendApi.endpoints.getArchitectures.select`; if possible, tightening this typing (e.g. via a discriminated union or a typed wrapper around `backendApi`) would avoid the escape hatch and make the middleware safer to refactor.

## Individual Comments

### Comment 1
<location path="src/store/slices/wizard/listeners.ts" line_range="46-55" />
<code_context>
+  );
+};
+
+// This was previously a mutation inside the changeDistribution reducer.
+// As a listener it fires *after* the reducer commits, so any other listener
+// reading the `registration.type` in the same tick will observe the old value
+// until this dispatch is processed.
+export const registerLater: WizardListenerEffect = (_action, listenerApi) => {
+  const state = listenerApi.getState();
+  const distribution = selectDistribution(state);
+
+  if (process.env.IS_ON_PREMISE && !isRhel(distribution)) {
+    listenerApi.dispatch(changeRegistrationType('register-later'));
+  }
+};
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Moving registration-type changes into a listener may introduce ordering subtleties

Previously, `changeDistribution` updated `output.distribution` and `registration.type` atomically in one reducer. With `registerLater` as a listener, `registration.type` now changes in a separate dispatch after the reducer completes. This can temporarily desynchronize `distribution` and `registration.type` if other listeners or UI code read both in the same tick. If that ordering matters, either move this back into the reducer or ensure downstream consumers only react to `registration.type` changes and don’t assume atomic updates with `distribution`.

Suggested implementation:

```typescript

```

1. In the `changeDistribution` reducer (likely in `src/store/slices/wizard/slice.ts` or a similar file), reintroduce the registration-type update that was previously moved into the `registerLater` listener, e.g.:
   - When `process.env.IS_ON_PREMISE` is true and the new distribution is not RHEL, set `registration.type = 'register-later'` in the same reducer branch that updates `output.distribution`.
2. Ensure that any removed imports used only by `registerLater` (such as `selectDistribution`, `isRhel`, `WizardListenerEffect`, or `changeRegistrationType` if it was only used here) are cleaned up from `listeners.ts` to avoid unused-import warnings.
3. Verify that no other listeners or UI components now assume that `registration.type` is driven by a separate `changeRegistrationType('register-later')` dispatch; they should instead rely on the atomic update inside `changeDistribution`.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.65%. Comparing base (fee56e6) to head (41b7fd1).

@@            Coverage Diff             @@
##             main    #4566      +/-   ##
==========================================
- Coverage   76.70%   76.65%   -0.06%     
==========================================
  Files         248      247       -1     
  Lines        7131     7114      -17     
  Branches     2650     2641       -9     
==========================================
- Hits         5470     5453      -17     
  Misses       1436     1436              
  Partials      225      225              

Files with missing lines	Coverage Δ
...ard/steps/ImageOutput/components/ReleaseSelect.tsx	94.91% <ø> (ø)
...omponents/ImageOverview/components/MiscFormats.tsx	100.00% <ø> (ø)
...ponents/ImageOverview/components/PrivateClouds.tsx	100.00% <ø> (ø)
...ts/ImageOverview/components/PublicClouds/index.tsx	100.00% <ø> (ø)
...nents/CreateImageWizard/utilities/requestMapper.ts	76.33% <ø> (ø)
...Hooks/Utilities/useTargetEnvironmentCategories.tsx	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fee56e6...41b7fd1. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.