imgtestlib: handle manifests without org.osbuild.curl sources#2408
Closed
lzap wants to merge 1 commit into
Closed
Conversation
The can_boot_test() function assumed network-installer manifests always have org.osbuild.curl sources containing ssh-server packages. However, bootc-based images don't use curl sources and have a different manifest structure. This commit adds a check to handle manifests that lack the org.osbuild.curl key gracefully. If the key is missing, the function returns True (bootable) since the ssh-server check only applies to network-installer types. Fixes KeyError when testing bootc qcow2 images. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
avitova
reviewed
Jun 9, 2026
Comment on lines
+432
to
+433
| if "org.osbuild.curl" not in manifest_data.get("sources", {}): | ||
| return True |
Contributor
There was a problem hiding this comment.
Shouldn't we return False? https://github.com/osbuild/images/pull/2406/changes
Contributor
Author
There was a problem hiding this comment.
Bootc is actually bootable without any curl source. Data come in a different way (container repo ref).
Member
|
maybe let's use da4ea14 |
Contributor
Author
|
Since there is prior art, I am closing in favour to #2406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The can_boot_test() function assumed network-installer manifests always have org.osbuild.curl sources containing ssh-server packages. However, bootc-based images don't use curl sources and have a different manifest structure.
osbuild/bootc-foundry#96