BootcDiskImage: Support using a custom container for the build pipeline #1507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running the build with a policy other than "targeted".
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image.
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 9, 2025
…iner The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
Contributor
Author
|
This is used in osbuild/bootc-image-builder#921 |
Member
For this specific function it is (IMHO) fine to change the API as there is only one consumer ( |
Contributor
Author
|
Closed in favor of #1519 |
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 14, 2025
…iner The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 15, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 16, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 16, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 20, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 21, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
alexlarsson
added a commit
to alexlarsson/bootc-image-builder
that referenced
this pull request
May 22, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
achilleas-k
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
May 22, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
mvo5
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Nov 19, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
mvo5
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Nov 25, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
mvo5
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Nov 27, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
mvo5
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Dec 3, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
mvo5
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Dec 8, 2025
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image. This depends on osbuild/images#1507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automotive project wants to build minimal bootc images which will not contain tools like dnf, mkfs.ext, etc. We support this by allowing the container used in the build pipeline to come from another (but related) container image.
Note: This depends on, and includes the commits from, #1506
Question: This just changes the API, what are the policy here? Is this fine, or should I duplicate NewBootcDiskImage() to NewBootcDiskImageWithBuild() so the old calls keep working?