Update check-snapshots to include an update functionality #4719
Conversation
|
Hey. Thanks for the PR. I haven't read through it in detail yet. I invited you to one of the org teams with write access so that your PR checks run without needing approval. Could you please clean up the git history a bit? Please have a look at our commit message guidelines: https://osbuild.org/docs/developer-guide/general/workflow/#preferred-commit-message-format Some of the commit message summaries are a bit too long. Also some commits could be squashed for cleaner history. The |
|
Also, please separate changes to the tool from changes to the json files into their own commits. |
using `./tools/check-snapshots -u .` will update the test repo files with any NEWER updates Signed-off-by: John Castranio <[email protected]>
PicklesMcDougan
force-pushed
the
update_check-snapshots
branch
from
c9f8a8e to
b29350a
Compare
updates to test repositories based on tools/check-updates
|
Err. And now I'm confused, this PR is opened against rhel-9.2.0 not the main branch. Was that on purpose? |
|
@bcl My understanding was that the more recent branches had a method for updating the snapshot urls. People were out on leave so I was just working on how to fix the failing tests for the 9.2 branch, since 9.4 was working. I am unaware if the newer branches are working simply because the snapshots are still valid, or if there was another method to update those repo urls. Outside of whatever I've done to upset Schultzbot, I'm happy to update or cancel this request in order to do whatever would be best |
|
I'm not seeing the update option in the current version of the script on main, did you add that yourself or copy it from somewhere? I'm likely missing some context here related to the older branches though. |
Added a new functionality to the tools/check-snapshots utility to allow automatic updates of any files with newer results.
./tools/check-snapshots -u .