-
Notifications
You must be signed in to change notification settings - Fork 81
feat!: adds initail monorepo structure #1904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat!: adds initail monorepo structure #1904
Conversation
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
ee56fa6 to
ac82dce
Compare
|
@degenaro @vikas-agarwal76 @butler54 Opening this for early feedback. I'm running into some test failures in a couple pipelines, and haven't had a chance to fully investigate yet. If anyone has the time to take a look and offer suggestions on fixing these, your help would be greatly appreciated! |
|
After a brief review, this looks like a great start. Some random comments:
- should trestle-cli and trestle-sdk have similar sub-structure? For
example, trestle-sdk has *src* but trestle-cli has *trestle*.
- should both have *tests*?
- we seem to be inconsistent with respect to use of hyphen and underscore
in folder names
…On Mon, Jul 14, 2025 at 8:12 PM Jennifer Power ***@***.***> wrote:
*jpower432* left a comment (oscal-compass/compliance-trestle#1904)
<#1904 (comment)>
@degenaro <https://github.com/degenaro> @vikas-agarwal76
<https://github.com/vikas-agarwal76> @butler54
<https://github.com/butler54> Opening this for early feedback. I'm
running into some test failures in a couple pipelines, and haven't had a
chance to fully investigate yet. If anyone has the time to take a look and
offer suggestions on fixing these, your help would be greatly appreciated!
—
Reply to this email directly, view it on GitHub
<#1904 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD66XNLT2RKRL23CTGF4LT3IRBP3AVCNFSM6AAAAACBQLRMXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANZRGM4TCNRZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This structure was created by
I think they should, but
Good catch! Thanks. I can take a look at that. |
|
I'll take a look at this see what we want to do moving forward |
|
This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. |
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Adds
uvmonorepo implementation. This is still WIP and very early. Adding a PR for early feedback.Closes #1877
Key links:
Before you merge