Skip to content

Conversation

@jpower432
Copy link
Member

@jpower432 jpower432 commented Jul 14, 2025

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Adds uv monorepo implementation. This is still WIP and very early. Adding a PR for early feedback.
Closes #1877

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@jpower432 jpower432 force-pushed the feat/monorepo-structure branch from ee56fa6 to ac82dce Compare July 14, 2025 23:34
@jpower432
Copy link
Member Author

@degenaro @vikas-agarwal76 @butler54 Opening this for early feedback. I'm running into some test failures in a couple pipelines, and haven't had a chance to fully investigate yet. If anyone has the time to take a look and offer suggestions on fixing these, your help would be greatly appreciated!

@degenaro
Copy link
Collaborator

degenaro commented Jul 15, 2025 via email

@jpower432
Copy link
Member Author

Some random comments:

  • should trestle-cli and trestle-sdk have similar sub-structure? For example, trestle-sdk has src but trestle-cli has trestle.

This structure was created by uv init. trestle-sdk has src because I set it as a library type.

  • should both have tests?

I think they should, but trestle-sdk only have the OSCAL classes right now that did not have associated tests.

  • we seem to be inconsistent with respect to use of hyphen and underscore in folder names

Good catch! Thanks. I can take a look at that.

@butler54 butler54 self-requested a review October 9, 2025 05:16
@butler54
Copy link
Contributor

butler54 commented Oct 9, 2025

I'll take a look at this see what we want to do moving forward

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed approach for managing the Trestle SDK

3 participants