Skip to content

Conversation

@1aur
Copy link

@1aur 1aur commented Nov 22, 2025

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

This PR updates the NIST SP 800-53 Rev 5-related CSV/xlsx tasks and tests so that the rev5 workflows are consistent:

  • Updated good.xlsx and embedded_blank_in_parameter_name.xlsx test spreadsheets to align with the current NIST SP 800-53 Rev 5 catalog content.
  • Adjusted tests/data/tasks/xlsx/output/component-definition.json and test-xlsx-to-oscal-cd.config so the generated component definition output and UUID expectations are stable.
  • Updated csv_to_oscal_cd_test.py and oscal_catalog_to_csv_test.py to match the latest rev5 catalog row counts and spot-check assertions.
  • Verified that all task-related tests pass locally via pytest tests/trestle/tasks.

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@1aur 1aur requested a review from a team as a code owner November 22, 2025 01:03
@1aur 1aur changed the title rev5 tasks update feat: Update NIST 800-53 rev5 CSV/xlsx tasks and tests Nov 22, 2025
@1aur 1aur changed the title feat: Update NIST 800-53 rev5 CSV/xlsx tasks and tests feat: update NIST 800-53 rev5 CSV/xlsx tasks and tests Nov 22, 2025
@degenaro
Copy link
Collaborator

degenaro commented Dec 2, 2025

@1aur Do you want to meet on Teams to move these PRs forward? Soon or once semester ends?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants