Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
=======================================
Coverage 76.40% 76.40%
=======================================
Files 61 61
Lines 4945 4945
=======================================
Hits 3778 3778
Misses 1167 1167 🚀 New features to boost your workflow:
|
lgoettgens
left a comment
There was a problem hiding this comment.
If it helps you, please add it. I haven't looked at JET reports in a while.
It would make sense to at least try it |
|
Side-remark: When looking at a JET report, I just got two potential issues related to |
Will be fixed by JuliaLang/julia#60645 With these things fixed, do we then really need this script? |
|
We don't need the script for this usecase, but I'd like to keep it around for the time being because it can be very helpful for ignoring things, so one can focus on what really matters. Also, I'll try to submit the code to JET. Anyway, let's keep this around for a bit (so I don't loose it / forget it) |
Specifically, don't report anythin related to our unholy is_loaded_directly hack. We know it's evil, no need to see JET get twisted up about it.
5382344 to
e994993
Compare
Specifically, don't report anythin related to our unholy
is_loaded_directly hack. We know it's evil, no need to see
JET get twisted up about it.
Similar scripts could / should be add to our other packages,
with possible more things to ignore added for each, as needed.
The
AnyFrameMethodcould also perhaps be submitted to JET,dunno if there'd be interest.