Skip to content

Add script for running JET with options#1312

Draft
fingolfin wants to merge 1 commit intomasterfrom
mh/jet-script
Draft

Add script for running JET with options#1312
fingolfin wants to merge 1 commit intomasterfrom
mh/jet-script

Conversation

@fingolfin
Copy link
Member

Specifically, don't report anythin related to our unholy
is_loaded_directly hack. We know it's evil, no need to see
JET get twisted up about it.

Similar scripts could / should be add to our other packages,
with possible more things to ignore added for each, as needed.

The AnyFrameMethod could also perhaps be submitted to JET,
dunno if there'd be interest.

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.40%. Comparing base (a9fbc57) to head (e994993).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1312   +/-   ##
=======================================
  Coverage   76.40%   76.40%           
=======================================
  Files          61       61           
  Lines        4945     4945           
=======================================
  Hits         3778     3778           
  Misses       1167     1167           

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps you, please add it. I haven't looked at JET reports in a while.

@lgoettgens
Copy link
Member

The AnyFrameMethod could also perhaps be submitted to JET,
dunno if there'd be interest.

It would make sense to at least try it

@lgoettgens
Copy link
Member

Side-remark: When looking at a JET report, I just got two potential issues related to is_loaded_directly. One of them will be fixed by Nemocas/AbstractAlgebra.jl#2277, the other one is something genuine in julia Base (about show(io::IOContext{IOBuffer}, frame::Base.StackTraces.StackFrame)). Therefore, I would be interested if there are any more popping up for you (and with which combination of versions of julia and packages).

@lgoettgens
Copy link
Member

the other one is something genuine in julia Base (about show(io::IOContext{IOBuffer}, frame::Base.StackTraces.StackFrame)

Will be fixed by JuliaLang/julia#60645

With these things fixed, do we then really need this script?

@fingolfin
Copy link
Member Author

We don't need the script for this usecase, but I'd like to keep it around for the time being because it can be very helpful for ignoring things, so one can focus on what really matters.

Also, I'll try to submit the code to JET.

Anyway, let's keep this around for a bit (so I don't loose it / forget it)

Specifically, don't report anythin related to our unholy
is_loaded_directly hack. We know it's evil, no need to see
JET get twisted up about it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants