CI: pass --coverage to C/LDFLAGS when building JuliaInterface#1343
Draft
CI: pass --coverage to C/LDFLAGS when building JuliaInterface#1343
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
+ Coverage 78.03% 78.94% +0.90%
==========================================
Files 61 61
Lines 4945 4934 -11
==========================================
+ Hits 3859 3895 +36
+ Misses 1086 1039 -47 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bunch of C code in JuliaInterface that we definitely are exercising, but which Codecov does not report as covered. I am trying to figure out why. One guess is that we only enable the CFLAG
--coverwhen running thegaptests (inetc/ci_test.sh), so this PR tries to enable them also when running the JuliaInterface tests, at least in one case (the "treehash" CI check, as it already enablesFORCE_JULIAINTERFACE_COMPILATION=trueanyway).UPDATE: alas, it doesn't work and I am not really sure why