Generic cyclotomic ring #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 31, 2025
SoongNoonien
force-pushed
the
generic_cyclotomic_ring
branch
2 times, most recently
from
745e4f5 to
556d066
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 94.96% 95.10% +0.14%
==========================================
Files 13 13
Lines 913 920 +7
==========================================
+ Hits 867 875 +8
+ Misses 46 45 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SoongNoonien
force-pushed
the
generic_cyclotomic_ring
branch
from
556d066 to
a3cc5d0
Compare
fingolfin
reviewed
Apr 1, 2025
Co-authored-by: Max Horn <[email protected]>
fingolfin
approved these changes
Apr 3, 2025
|
Yes, ideally in the yet to be filled section about generic cyclotomics: https://oscar-system.github.io/GenericCharacterTables.jl/dev/cyclo/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the whole situation about
generic_cyclotomic_ring.