Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PolyhedralGeometry: more operators on fans and complexes #4444

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

formatting

3641724
Select commit
Loading
Failed to load commit list.
Draft

PolyhedralGeometry: more operators on fans and complexes #4444

formatting
3641724
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 31, 2025 in 0s

84.40% (-0.16%) compared to 3e86180

View this Pull Request on Codecov

84.40% (-0.16%) compared to 3e86180

Details

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.40%. Comparing base (3e86180) to head (3641724).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...ometry/PolyhedralComplex/standard_constructions.jl 93.10% 2 Missing ⚠️
...alGeometry/PolyhedralFan/standard_constructions.jl 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4444      +/-   ##
==========================================
- Coverage   84.55%   84.40%   -0.16%     
==========================================
  Files         672      672              
  Lines       88880    89167     +287     
==========================================
+ Hits        75152    75258     +106     
- Misses      13728    13909     +181     
Files with missing lines Coverage Δ
src/PolyhedralGeometry/helpers.jl 83.43% <ø> (ø)
src/PolyhedralGeometry/iterators.jl 92.26% <ø> (ø)
...ometry/PolyhedralComplex/standard_constructions.jl 94.87% <93.10%> (-5.13%) ⬇️
...alGeometry/PolyhedralFan/standard_constructions.jl 98.60% <83.33%> (-1.40%) ⬇️

... and 53 files with indirect coverage changes