-
Notifications
You must be signed in to change notification settings - Fork 141
Add dicyclic_group
, is_dicyclic_group
and have quaternion_group
and is_quaternion_group
be aliases of those
#4661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
76b93a0
Add dicyclic group constructor
jamesnohilly 18008ed
Change quaternion_group to be an alias of dicyclic_group
jamesnohilly fb5dda0
Add test for dicyclic_group
jamesnohilly 38a463e
Add changes from review
jamesnohilly 3d757e0
Fix format issue
jamesnohilly e07d330
Add converse tests and example
jamesnohilly 05ac3ec
Merge branch 'master' into jn/dicyclic
lgoettgens 36a690c
Merge docstring and alias constructors
jamesnohilly 1eb2831
Implement IsDicyclicGroup from GAP
jamesnohilly 83cfa4b
Seperate is_dicyclic and is_quaternion
jamesnohilly b09e726
Remove GAP attribute for is_dicyclic
jamesnohilly be0df31
Apply review comments
jamesnohilly 5fa9e97
Remove attribute export
jamesnohilly ca99ed5
Use @alias for aliases
jamesnohilly f424fef
Apply suggestions from code review
fingolfin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.