Introduce halfspace_matrix_pair(ZZ, ...)
#4709
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
halfspace_matrix_pair(ZZ, ...)
we can ask for integral representations of its content. This solves #4682 .In the following example we compare the default case to the integral case and the semi-integral case (i.e. b is not required to be integral, only A):
@lkastner can you play around and see if this meets your expactations? Also, from what I have tested this seemed to work properly for cones. Still, I did not like having to call
halfspace_matrix_pair
which gives us the redundant information that b is a zero vector. Do you think we should define a method ofmatrix
for this context? I guess this should not conflict with any other definition ofmatrix
, but if it does we could still find some appropriate function name.