-
Notifications
You must be signed in to change notification settings - Fork 140
Update changelog script #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update changelog script #4719
Conversation
Result at #4720 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
just talked and we don't merge this right now
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4719 +/- ##
==========================================
+ Coverage 84.84% 84.89% +0.05%
==========================================
Files 697 706 +9
Lines 94232 95341 +1109
==========================================
+ Hits 79949 80940 +991
- Misses 14283 14401 +118 🚀 New features to boost your workflow:
|
d6bdff0
to
e1c1a60
Compare
dev/releases/release_notes.py
Outdated
previous_minor = minor - 1 | ||
basetag = f"v{major}.{minor}dev" | ||
basetag = f"{major}.{minor}dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why drop the v
?
basetag = f"{major}.{minor}dev" | |
basetag = f"v{major}.{minor}dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to an inconsistency (and I didn't look back far enough)
$ git tag --list | grep 'dev'
1.5dev
v1.4dev
The latest tag doesn't have the v
in front of it. But 1.4 does (and I didn't look that far back, just tried making changelog for 1.5.0).
How do we handle this? Do we add back the v
in code, and make a new tag identical to 1.5dev
, but call it v1.5dev
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me no, only don't understand why that one tag value was changed
Summary after discussing privately with @fingolfin :
Thoughts @lgoettgens @benlorenz ? |
I think we should use the version with |
Seems like a human mistake on my side. I am happy to have either documentation or some automation regarding this to reduce the possibility of future similar errors |
[skip-ci]
[skip-ci]
I have restored the |
I propose we do that in a separate PR. |
Updates the changelog workflow to allow for an optional basetag. Also pushes change log stuff to ignore list for CI
Resolves #4666
Resolves #4670
Resolves #4671