Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Include 1/2 c2 in identification of flux families #4728

Merged
merged 56 commits into from
Apr 3, 2025

Conversation

HereAround
Copy link
Member

@HereAround HereAround added topic: FTheoryTools enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes WIP NOT ready for merging labels Mar 10, 2025
@HereAround HereAround force-pushed the ExpandFluxComputation branch from be82871 to fce8b05 Compare March 10, 2025 22:18
@HereAround HereAround force-pushed the ExpandFluxComputation branch 11 times, most recently from 6caf7ed to f00f9bb Compare March 11, 2025 18:19
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 25.40193% with 232 lines in your changes missing coverage. Please review.

Project coverage is 84.30%. Comparing base (2597903) to head (9abd5de).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...xperimental/FTheoryTools/src/G4Fluxes/auxiliary.jl 0.00% 185 Missing ⚠️
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 58.25% 43 Missing ⚠️
...heoryTools/src/AbstractFTheoryModels/attributes.jl 66.66% 2 Missing ⚠️
.../FTheoryTools/src/FamilyOfG4Fluxes/constructors.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4728      +/-   ##
==========================================
- Coverage   84.39%   84.30%   -0.09%     
==========================================
  Files         674      673       -1     
  Lines       90309    90328      +19     
==========================================
- Hits        76212    76150      -62     
- Misses      14097    14178      +81     
Files with missing lines Coverage Δ
...al/FTheoryTools/src/FamilyOfG4Fluxes/attributes.jl 73.33% <100.00%> (+3.47%) ⬆️
...ental/FTheoryTools/src/FamilyOfG4Fluxes/methods.jl 96.96% <100.00%> (+0.14%) ⬆️
...al/FTheoryTools/src/FamilyOfG4Fluxes/properties.jl 70.42% <100.00%> (+1.30%) ⬆️
...eoryTools/src/Serialization/hypersurface_models.jl 97.05% <ø> (ø)
...ntal/FTheoryTools/src/Serialization/tate_models.jl 0.00% <ø> (ø)
...heoryTools/src/Serialization/weierstrass_models.jl 100.00% <ø> (ø)
experimental/FTheoryTools/src/types.jl 76.19% <100.00%> (ø)
...heoryTools/src/AbstractFTheoryModels/attributes.jl 96.67% <66.66%> (+2.21%) ⬆️
.../FTheoryTools/src/FamilyOfG4Fluxes/constructors.jl 73.80% <71.42%> (+0.12%) ⬆️
...Tools/src/FamilyOfG4Fluxes/special_constructors.jl 63.86% <58.25%> (+12.87%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HereAround HereAround force-pushed the ExpandFluxComputation branch 2 times, most recently from c959227 to bd7b272 Compare March 13, 2025 11:49
@HereAround HereAround changed the title [FTheoryTools] Shift computed flux families by -1/2 c2 to reflect flux quantization condition in full generality [FTheoryTools] Include 1/2 c2 in identification of flux families Mar 13, 2025
@HereAround HereAround force-pushed the ExpandFluxComputation branch 5 times, most recently from 7d1cf2b to faf051f Compare March 19, 2025 23:40
@HereAround HereAround force-pushed the ExpandFluxComputation branch 3 times, most recently from 53a2e4f to ab2965a Compare March 21, 2025 10:00
HereAround and others added 27 commits April 3, 2025 10:47
@HereAround HereAround force-pushed the ExpandFluxComputation branch from 172cbfc to 523512d Compare April 3, 2025 08:47
@HereAround HereAround merged commit 7841db6 into oscar-system:master Apr 3, 2025
32 checks passed
@HereAround HereAround deleted the ExpandFluxComputation branch April 3, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants