Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talk ebernburg #4738

Open
wants to merge 84 commits into
base: master
Choose a base branch
from
Open

Talk ebernburg #4738

wants to merge 84 commits into from

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Mar 17, 2025

No description provided.

ThomasBreuer and others added 30 commits February 21, 2025 14:52
- address comments
- decide about cyclic defect groups of blocks without using the group
…aracteristic. (#4615)

* enable use good reduction for pushforward_on_algebraic_lattice

* pass on is_isomorphism in composition

* enable use good reduction for pushforward_on_algebraic_lattice

---------

Co-authored-by: HechtiDerLachs <[email protected]>
* Relax a signature

to e.g. allow a matrix group over ZZ act on QQMatrix

* Move `map_word(::WeylGroupElem, ::Vector)` to src

* Add `(dual_)geometric_representation(::WeylGroup)`

* Add `is_finite_order(::WeylGroupElem)` and `order(::WeylGroupElem)`

* Enable group conformance tests

* Add `matrix_group_type`, `ZZMatrixGroup`, and `QQMatrixGroup`
Evaluating a rational function seems natural enough, but
implementing it here is type piracy.
* Use imperative form in (first sentence of) docstrings

As suggested by the Julia manual, see
<https://docs.julialang.org/en/v1/manual/documentation/>
* Remove calls to gap_to_julia in SLP code
* Replace a gap_to_julia call by `syllables`
* Remove `gap_to_julia` in character table translation
* Remove `gap_to_julia` tests
HereAround and others added 11 commits March 13, 2025 13:37
* Include linear solving doc page in the Oscar docs

* Bumb AA compat
…4697)

This broken shortcut was originally added in a joint project with
Henriksson and Helminck.  The idea was that groebner_basis should not
do anything for binomial ideals if the weight vector lies on the
tropicalization (the weight vector test was missing).  While this is
mathematically correct, it is on second thought not a good idea if
groebner_basis for binomial ideals behaves differently than for
general ideals, so I am taking this out.
@lgoettgens
Copy link
Member

The history is kind of messed up here (lots of unrelated commits from master contained in the PR). And with #4628 now merged, it would make sense to rebase this on top of the latest master to get a better grasp of the contained changes.

@fieker fieker force-pushed the Talk_Ebernburg branch 2 times, most recently from 297479c to 86babd6 Compare March 19, 2025 17:05
@fieker
Copy link
Contributor Author

fieker commented Mar 19, 2025

hopefully the history is "sorted" how it got messed up: no idea

@lgoettgens
Copy link
Member

already a lot better, thanks! There are only two more serialization related commits in there

@fieker
Copy link
Contributor Author

fieker commented Mar 19, 2025 via email

@lgoettgens
Copy link
Member

Now this has some conflicts, I would guess due to #4742.

fieker added 8 commits March 25, 2025 22:00
(embarassing error...)
This currently works:

  A = matrix_algebra(QQ, 2)

  k, a = quadratic_field(3)
  T = matrix(k, 2, 2, [rand(k, -10:10) for i=1:4])
  F = free_module(k, 2)
  h = [hom(F, F, T*matrix(x)*inv(T)) for x = gens(A)]
  a = gmodule(nothing, h)
  Oscar.GModuleFromGap._minimize(a)

should be back over QQ (as a number field)
fieker added 3 commits March 28, 2025 17:55
and start with Algebras...(in _minimize)
there is a non-trivial example in the doc string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.