Skip to content

Fix cached orbits inside orbits #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Fix cached orbits inside orbits #4753

merged 2 commits into from
Mar 31, 2025

Conversation

lgoettgens
Copy link
Member

Resolves #4752.

@lgoettgens lgoettgens mentioned this pull request Mar 21, 2025
Closed
ThomasBreuer
ThomasBreuer approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks o.k.

mjrodgers
mjrodgers approved these changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@mjrodgers mjrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, too

@fingolfin fingolfin merged commit fbd6cb0 into oscar-system:master Mar 31, 2025
32 checks passed
@lgoettgens lgoettgens deleted the lg/orbit-caching branch April 1, 2025 07:07
@lgoettgens lgoettgens added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes backport 1.3.x backport for release branch 1.3 labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjrodgers mjrodgers mjrodgers approved these changes

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@fingolfin fingolfin Awaiting requested review from fingolfin

Assignees
No one assigned
Labels
backport 1.3.x backport for release branch 1.3 release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: groups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typeassert error in orbits(::GSetByElements{PermGroup, Int64})
4 participants
@lgoettgens @mjrodgers @ThomasBreuer @fingolfin