-
Notifications
You must be signed in to change notification settings - Fork 139
New wrapper for Singular triangular decompositions #4765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New wrapper for Singular triangular decompositions #4765
Conversation
Minor nitpick: I think we don't capitalize anything, not even names. So the algorithm symbols should also all be lowercase (and snakecase). (For example, the option for groebner bases is called So I guess it would be |
909e43a
to
4616668
Compare
No problem, that was an easy change. |
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
302f6f1
to
ba664c3
Compare
ba664c3
to
967d5ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thank you for doing this.
Just as a sideremark: the doctests do not completely test the example, as some of the results are not spelled out due to size. But I do not see this as a problem for this particular code, as it is only wrapping a (stable) Singular-library command.
@afkafkafk13 I have added the option to specify the ordering of the variables for the triangular decomposition (which I need for my tropical code) through a keyword argument |
Co-authored-by: Anne Frühbis-Krüger <[email protected]>
@YueRen : Resolving the conflict in the bib-file seems to have messed up the file, but I do not see what goes wrong. (Everything was fine with your addition, master was fine with the addition of Lan71, but now bibtool complains) |
The bibliography should be fixed now, just a problem with the ordering of the bib entries. |
And sorry for the unnecessary deletion of a trailing whitespace in docs/src/CommutativeAlgebra/ideals.md, my editor is overzealous at times.