-
Notifications
You must be signed in to change notification settings - Fork 139
Stabilize booktests in vinberg
#4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize booktests in vinberg
#4766
Conversation
Co-authored-by: Max Horn <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4766 +/- ##
==========================================
- Coverage 84.57% 84.33% -0.25%
==========================================
Files 674 675 +1
Lines 90802 91066 +264
==========================================
+ Hits 76798 76801 +3
- Misses 14004 14265 +261
🚀 New features to boost your workflow:
|
For the sake of our sanity upstream, I will mark this to be backported. (In case we will have another 1.3.* release before 1.4.) |
This reverts commit e25017f.
@simonbrandhorst : Could you maybe approve this? I did not change any mathematics, only the algorithmic path to get to our results. Feel free to contact me on Slack if in doubt. |
This is an attempt to hopefully stabilize the booktests; see #4493.