Skip to content

Stabilize booktests in vinberg #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HechtiDerLachs
Copy link
Collaborator

This is an attempt to hopefully stabilize the booktests; see #4493.

Co-authored-by: Max Horn <[email protected]>
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (ae6f43f) to head (fde7fdf).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4766      +/-   ##
==========================================
- Coverage   84.57%   84.33%   -0.25%     
==========================================
  Files         674      675       +1     
  Lines       90802    91066     +264     
==========================================
+ Hits        76798    76801       +3     
- Misses      14004    14265     +261     
Files with missing lines Coverage Δ
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl 81.03% <100.00%> (-0.38%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thofma
Copy link
Collaborator

thofma commented Apr 1, 2025

For the sake of our sanity upstream, I will mark this to be backported. (In case we will have another 1.3.* release before 1.4.)

@thofma thofma added the backport 1.3.x backport for release branch 1.3 label Apr 1, 2025
@HechtiDerLachs
Copy link
Collaborator Author

@simonbrandhorst : Could you maybe approve this? I did not change any mathematics, only the algorithmic path to get to our results. Feel free to contact me on Slack if in doubt.

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) April 2, 2025 13:39
@simonbrandhorst simonbrandhorst added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Apr 2, 2025
@simonbrandhorst simonbrandhorst merged commit 77888aa into oscar-system:master Apr 2, 2025
32 checks passed
@HechtiDerLachs HechtiDerLachs deleted the stabilize_booktests branch April 4, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3.x backport for release branch 1.3 release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants