-
Notifications
You must be signed in to change notification settings - Fork 139
fix exponentation of tropical polynomials #4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix exponentation of tropical polynomials #4767
Conversation
Do you have a reference for the characteristic of semirings? (Other than a stackexchange link) |
Not at hand, but I'll ask around. |
It seems that I was mistaken. The correct characteristic of the tropical numbers (or any idempotent semiring) is 1. Maybe it's better to remove that function then, in case some other Oscar function implicitly assumes that characteristic is either 0 or prime. |
02d1371
to
f4298e2
Compare
225c78e
to
40f6146
Compare
It might also be useful to place a meaningful error pointing out that the characteristic of the tropical semiring is not available by choice and not by chance (as it is always 1 and might confuse ring functionality). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now.
I have added an error that the characteristic of tropical semirings is not supported. I've thought of ways to make the error more verbose, but what elaboration makes sense strongly depends on how the user encounters the error. |
I alreay saw it and approved it. The degree of elaboration in the error message is fine. |
Solves a bug reported by @shelbycox via slack.