Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more serialization of stuff around localizations #4773

Conversation

HechtiDerLachs
Copy link
Collaborator

Copy link
Collaborator

@antonydellavecchia antonydellavecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments and suggestions

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 75.53191% with 23 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (4f654db) to head (213695a).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/Serialization/main.jl 0.00% 15 Missing ⚠️
src/Serialization/Rings.jl 94.66% 4 Missing ⚠️
src/Serialization/parallel.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4773      +/-   ##
==========================================
- Coverage   84.35%   84.34%   -0.02%     
==========================================
  Files         675      676       +1     
  Lines       91069    91176     +107     
==========================================
+ Hits        76825    76903      +78     
- Misses      14244    14273      +29     
Files with missing lines Coverage Δ
src/Rings/mpolyquo-localizations.jl 74.63% <ø> (+0.15%) ⬆️
src/Serialization/Rings.jl 96.53% <94.66%> (-0.43%) ⬇️
src/Serialization/parallel.jl 87.25% <0.00%> (-3.57%) ⬇️
src/Serialization/main.jl 86.72% <0.00%> (-4.22%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@antonydellavecchia antonydellavecchia merged commit 4bb9fe8 into oscar-system:master Apr 3, 2025
61 of 68 checks passed
@antonydellavecchia antonydellavecchia deleted the localization_serialization_second_attempt branch April 3, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants